Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Relation field wrong dirty detector and "losing" data even without any changes #364

Merged
merged 4 commits into from
Dec 4, 2023
Merged

[Bug]: Relation field wrong dirty detector and "losing" data even without any changes #364

merged 4 commits into from
Dec 4, 2023

Conversation

robertSt7
Copy link
Contributor

No description provided.

@robertSt7 robertSt7 added the Bug label Nov 30, 2023
@robertSt7 robertSt7 added this to the 1.2.3 milestone Nov 30, 2023
kingjia90
kingjia90 requested changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@kingjia90 kingjia90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, even though is quite hardcoded, should be a custom property or so.

  • should it be something like clearBeforeDestroy
    image and check the value here?

  • If you open and save without any changes, it would still flag it as dirty field

public/js/pimcore/asset/metadata/grid.js Outdated Show resolved Hide resolved
@robertSt7
Copy link
Contributor Author

see https://github.com/pimcore/asset-metadata-class-definitions/pull/155

@kingjia90 kingjia90 merged commit e422dca into 1.2 Dec 4, 2023
4 checks passed
@kingjia90 kingjia90 deleted the 151-bug-relation-field-wrong-dirty-detector-and-losing-data-even-without-any-changes branch December 4, 2023 10:29
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kingjia90 kingjia90 kingjia90 requested changes

Assignees

@kingjia90 kingjia90

Labels
Bug
Projects
None yet
Milestone
1.2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@robertSt7 @kingjia90