Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many-to-many-relations: support multi-file-upload #137

Merged
merged 13 commits into from
Feb 27, 2024

Conversation

BlackbitDevs
Copy link
Contributor

@BlackbitDevs BlackbitDevs commented Jun 22, 2023

For (advanced) many-to-many relations with assets being allowed you can directly upload assets from the relation view:
Bildschirmfoto 2023-06-22 um 16 09 09

Currently this only supports single-file uploads. The same applies under assets context menu for "Upload (Compatibility mode)". With this PR all those places now support multi-file upload.

@BlackbitDevs BlackbitDevs changed the title support multi upload assets Many-to-many-relations: support multi-upload Jun 22, 2023
@BlackbitDevs BlackbitDevs changed the title Many-to-many-relations: support multi-upload Many-to-many-relations: support multi-file-upload Jun 22, 2023
@BlackbitDevs BlackbitDevs marked this pull request as ready for review June 22, 2023 15:06
@kingjia90 kingjia90 added this to the 1.1.0 milestone Jul 11, 2023
@aryaantony92 aryaantony92 modified the milestones: 1.1.0, 1.2.0 Aug 8, 2023
@dvesh3 dvesh3 removed this from the 1.2.0 milestone Sep 26, 2023
@dvesh3 dvesh3 added this to the 1.3.0 milestone Nov 14, 2023
@dvesh3 dvesh3 modified the milestones: 1.3.0, 1.4.0 Nov 22, 2023
@robertSt7
Copy link
Contributor

@BlackbitDevs Could you please replace var with let and const. Thank you

Copy link

Please retry analysis of this Pull-Request directly on SonarCloud

public/js/pimcore/helpers.js Outdated Show resolved Hide resolved
@kingjia90
Copy link
Contributor

One minor graphical thing is that the popup that appears when clicking on the upload button, it doesn't hint that you can select one or more files
image

@BlackbitDevs
Copy link
Contributor Author

One minor graphical thing is that the popup that appears when clicking on the upload button, it doesn't hint that you can select one or more files

Actually people will assume this as they know it from other applications, won't they?
Of course we could change the placeholder to "Select files" - this should include one or multiple. WDYT?

@kingjia90
Copy link
Contributor

Yes, that's right, the text change would be fine to me

@BlackbitDevs
Copy link
Contributor Author

Changed to "Select files" - the non-english translations are still maintained outside of github, right?

@kingjia90
Copy link
Contributor

Yes, but i would use a new translation key instead.

public/js/pimcore/helpers.js Outdated Show resolved Hide resolved
public/js/pimcore/helpers.js Outdated Show resolved Hide resolved
public/js/pimcore/helpers.js Outdated Show resolved Hide resolved
public/js/pimcore/helpers.js Outdated Show resolved Hide resolved
public/js/pimcore/helpers.js Outdated Show resolved Hide resolved
public/js/pimcore/helpers.js Outdated Show resolved Hide resolved
translations/admin.en.yaml Outdated Show resolved Hide resolved
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud

@kingjia90 kingjia90 merged commit b9a2f58 into pimcore:1.x Feb 27, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants