Skip to content

test: skip query test on node <22 #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

test: skip query test on node <22 #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
308a5cb
test: skip query test on node <22
nathanhleung Jun 29, 2025
3a0c37e
refactor: split query skip logic into separate utility
nathanhleung Jun 29, 2025
46a0377
style: lint
nathanhleung Jun 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/route.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ const shouldHaveBody = utils.shouldHaveBody
const shouldHitHandle = utils.shouldHitHandle
const shouldNotHaveBody = utils.shouldNotHaveBody
const shouldNotHitHandle = utils.shouldNotHitHandle
const shouldSkipQueryHttpMethod = utils.shouldSkipQueryHttpMethod
const methods = utils.methods

describe('Router', function () {
Expand Down Expand Up @@ -254,7 +255,8 @@ describe('Router', function () {
// CONNECT is tricky and supertest doesn't support it
return
}
if (method === 'query' && process.version.startsWith('v21')) {

if (shouldSkipQueryHttpMethod()) {
return
}

Expand Down
7 changes: 5 additions & 2 deletions test/router.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const shouldHaveBody = utils.shouldHaveBody
const shouldHitHandle = utils.shouldHitHandle
const shouldNotHaveBody = utils.shouldNotHaveBody
const shouldNotHitHandle = utils.shouldNotHitHandle
const shouldSkipQueryHttpMethod = utils.shouldSkipQueryHttpMethod
const methods = utils.methods

describe('Router', function () {
Expand Down Expand Up @@ -51,7 +52,8 @@ describe('Router', function () {
// CONNECT is tricky and supertest doesn't support it
return cb()
}
if (method === 'query' && process.version.startsWith('v21')) {

if (shouldSkipQueryHttpMethod()) {
return cb()
}

Expand Down Expand Up @@ -317,7 +319,8 @@ describe('Router', function () {
// CONNECT is tricky and supertest doesn't support it
return
}
if (method === 'query' && process.version.startsWith('v21')) {

if (shouldSkipQueryHttpMethod()) {
return
}

Expand Down
7 changes: 7 additions & 0 deletions test/support/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ exports.shouldHaveBody = shouldHaveBody
exports.shouldNotHaveBody = shouldNotHaveBody
exports.shouldHitHandle = shouldHitHandle
exports.shouldNotHitHandle = shouldNotHitHandle
exports.shouldSkipQueryHttpMethod = shouldSkipQueryHttpMethod
exports.methods = methods

function createHitHandle (num) {
Expand Down Expand Up @@ -140,3 +141,9 @@ function shouldNotHaveHeader (header) {
assert.ok(!(header.toLowerCase() in res.headers), 'should not have header ' + header)
}
}

// Skipping HTTP QUERY tests below Node 22, QUERY wasn't fully supported by Node until 22
function shouldSkipQueryHttpMethod () {
const majorVersion = Number(process.versions.node.split('.')[0])
return majorVersion < 22
}