Merged
Conversation
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Pull Request Test Coverage Report for Build 17015694733Details
💛 - Coveralls |
Member
Author
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Member
Author
|
I've reviewed the changes several times, it only removes spaces, so it reduces lines of code, and that's why the build gets smaller. |
Member
Author
|
I added a .git-blame-ignore-revs so the blame doesn’t get messed up with these changes |
Merged
|
FYI: We are working on merging |
Member
Author
|
Ohhh, wow, I’m glad to hear that, that would be super cool |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Neostandard is being adopted as the linter. In Express we currently use Standard, but we’re planning to change it, though we don’t yet know which one. Anyway, there’s no issue in adopting this linter :), and it will also help us run type tests for this package, which I’ll try to add in a following PR after this one is merged