ci: use github actions instead travis#324
Merged
bjohansebas merged 17 commits intomasterfrom Aug 9, 2025
Merged
Conversation
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
bjohansebas
force-pushed
the
github_actions
branch
from
d1950e6 to
26f25c9
Compare
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
bjohansebas
force-pushed
the
github_actions
branch
from
5ff1cee to
ca6e2c3
Compare
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
bjohansebas
commented
Aug 9, 2025
Member
Author
bjohansebas
left a comment
bjohansebas
left a comment
There was a problem hiding this comment.
In the future, we need to drop support for older versions of Node.js, as running iconv on older Node.js versions in a newer Ubuntu release is really complicated.
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
bjohansebas
force-pushed
the
github_actions
branch
from
032c7e1 to
044d770
Compare
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title says, GitHub Actions will now be used, and the workflow is the same as the one used in Express
https://github.com/expressjs/express/blob/4.x/.github/workflows/ci.yml