Upgrade: using ES6 Module instead of CommonJS#279
Upgrade: using ES6 Module instead of CommonJS#279yosion-p wants to merge 6 commits intopillarjs:masterfrom
Conversation
|
Hey thank you for your effort here. I think it would work in general, but I can't accept it, at least for now, because iconv-lite supports pretty old Node versions and I don't want to lose this support. Not sure why Travis CI didn't provide test coverage here, otherwise it'd show exactly what versions are affected. |
|
Hi buddy, Due to these, maybe we need to upgrade the related Travis CI configuration, or to use Action CI(while it can't be compatible with older versions nodejs, but we can add it manually). What do you think? |
|
Hey, yep I believe you have the tests passing on latest node. What I wanted to see is them passing on older node versions, which I don't think can happen as the older versions don't support ES Modules. Travis-ci.org is dead, but travis-ci.com continues supporting public projects for free, so I just updated the config on its website and it should start checking all PRs and commits automatically. |
|
See #280 for an example. |
|
OK |
Hi buddy,
I upgraded the whole project from CommonJS to ES6 Module(#273 ).
Although there are still some issues which are mainly generation, test/performance and test/webpack,
but it passed all other UT.
I submitted the PR. Do you think it can work well in this way? If yes, I can fix the rest asap.