Skip to content

fix : check the chunk boundaries for surrogate pair #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yosion-p wants to merge 4 commits into from
Closed

fix : check the chunk boundaries for surrogate pair #275

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f91efb1
fix : check the chunk boundaries for surrogate pair
yosion-p Aug 16, 2021
f50aeb8
fix : delete only
yosion-p Aug 31, 2021
09d0832
Update streams-test.js
yosion-p Sep 9, 2021
3aaea23
Update streams-test.js
yosion-p Sep 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions test/streams-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,27 @@ if (!iconv.supportsStreams)

var Readable = require('stream').Readable;

// If surrogate pair, merge them
function formatSurrogate(arr) {
if(arr instanceof Array){
var h = arr[0],
l = arr[1]
if('\uD800' < h && h <= '\uDBFF' && '\uDC00' < l && l <= '\uDFFF'){
return [h+l]
}
}
return arr
}

// Create a source stream that feeds given array of chunks.
function feeder(chunks) {
if (!Array.isArray(chunks))
chunks = [chunks];
var opts = {};
if (chunks.every(function(chunk) {return typeof chunk == 'string'}))
opts.encoding = 'utf8';
if (chunks.every(function(chunk) {return typeof chunk == 'string'})){
opts.encoding = 'utf8';
chunks = formatSurrogate(chunks)
}

var stream = new Readable(opts);
function writeChunk() {
Expand Down Expand Up @@ -135,6 +149,12 @@ function checkDecodeStream(opts) {
}

describe("Streaming mode", function() {
it("Encoding using internal modules: utf8 with surrogates in separate chunks", checkEncodeStream({
encoding: "utf8",
input: ["\uD83D", "\uDE3B"],
output: "f09f98bb",
}));

it("Feeder outputs strings", checkStreamOutput({
createStream: function() { return feeder(["abc", "def"]); },
outputType: 'string',
Expand Down