Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ function finalhandler(req, res, options) {
res.statusCode = 500
}

// respect err.status
if (err.status) {
// respect err.status where applicable
if (err.status >= 400) {
res.statusCode = err.status
}

Expand Down
22 changes: 19 additions & 3 deletions test/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -90,18 +90,32 @@ describe('finalhandler(req, res)', function () {
.expect(503, done)
})

it('should override with err.status', function (done) {
it('should override with err.status when err.status is greater or equal to 400', function (done) {
var server = http.createServer(function (req, res) {
var done = finalhandler(req, res)
var err = new Error('oops')
res.statusCode = 503
err.status = 414
err.status = 400
done(err)
})

request(server)
.get('/foo')
.expect(414, done)
.expect(400, done)
})

it('should not override with err.status when err.status is less than 400', function (done) {
var server = http.createServer(function (req, res) {
var done = finalhandler(req, res)
var err = new Error('oops')
res.statusCode = 503
err.status = 200
done(err)
})

request(server)
.get('/foo')
.expect(503, done)
})
})

Expand Down Expand Up @@ -150,6 +164,8 @@ describe('finalhandler(req, res)', function () {
})
})
})


})

function createServer(err, opts) {
Expand Down