Kill pydantic from kraken
#370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilledk
approved these changes
Jul 30, 2022
goodboy
force-pushed
the
kraken_ws_orders
branch
from
c0617a5 to
e6a3e8b
Compare
goodboy
force-pushed
the
kill_pydantic_from_kraken
branch
from
f227fa8 to
44e21b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow these bits got missed during #353, no idea how but probably something to to with the #349 patchset still being in progress.
Note this PR should land on master after #369.
This coverts the remaining bits to use
msgspecequivalents inside thekrakenbackend:Struct.typecast()method to getpydantic-runtime-casting style conversion of field valuesOHLCstuff inkrakendata feed msg parsers to use our internal struct variant