Teardown guestmode via "root" cs around tractor.open_root_actor()
#211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodboy
changed the title
tractor.open_root_actor()tractor.open_root_actor()
goodboy
force-pushed
the
teardown_guesmost_via_cs
branch
from
56aa7e5 to
ffde4db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP testing to see if we can get
tractorto behave nicely if we have Qt teardown the actor tree via a top level (root)trio.CancelScopethat gets cancelled onlastWindowClosed().Right now it doesn't seem to be working in the non-
pikerdcase - closing the window can not only result in zombiebrokerds but also leave stale shm.. not sure how that's possible but k.We're probably going to need some explicit testing in
tractoritself likely in relation to goodboy/tractor#145.