Skip to content

Commit

Permalink
Remove dmlc headers, add optional DMLC_CORE_PATH variable for build p…
Browse files Browse the repository at this point in the history
…ath (apache#102)

* Remove dmlc headers, add optional DMLC_CORE_PATH variable for build path

* travis.yml doesn't need to clone dmlc-core anymore
  • Loading branch information
cjolivier01 authored and tqchen committed Jan 31, 2017
1 parent 97727ac commit a506679
Show file tree
Hide file tree
Showing 20 changed files with 19 additions and 3,935 deletions.
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
build
lib
*~
dmlc-core
cli_test
*.pyc

Expand Down
3 changes: 3 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
[submodule "plugin/nnvm-fusion"]
path = plugin/nnvm-fusion
url = https://github.com/dmlc/nnvm-fusion.git
[submodule "dmlc-core"]
path = dmlc-core
url = https://github.com/dmlc/dmlc-core
1 change: 0 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ addons:
- graphviz

before_install:
- git clone https://github.com/dmlc/dmlc-core
- source dmlc-core/scripts/travis/travis_setup_env.sh
- export PYTHONPATH=${PYTHONPATH}:${PWD}/python

Expand Down
6 changes: 6 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,12 @@ mxnet_source_group("Source\\pass" GLOB "src/pass/*.cc")

FILE(GLOB_RECURSE SOURCE "src/*.cc" "src/*.h" "include/*.h")

if(EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/dmlc-core/CMakeLists.txt)
include_directories(${CMAKE_CURRENT_SOURCE_DIR}/dmlc-core/include)
elseif(DMLC_CORE_PATH)
include_directories(${DMLC_CORE_PATH}/include)
endif()

add_library(nnvm ${SOURCE})
target_link_libraries(nnvm ${nnvm_LINKER_LIBS})

Expand Down
6 changes: 6 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@ include $(config)
export LDFLAGS = -pthread -lm
export CFLAGS = -std=c++11 -Wall -O2 -Iinclude -fPIC

ifdef DMLC_CORE_PATH
CFLAGS += -I$(DMLC_CORE_PATH)/include
else
CFLAGS += -I$(ROOTDIR)/dmlc-core/include
endif

ifneq ($(ADD_CFLAGS), NONE)
CFLAGS += $(ADD_CFLAGS)
endif
Expand Down
1 change: 1 addition & 0 deletions dmlc-core
Submodule dmlc-core added at 3a5161
2 changes: 0 additions & 2 deletions include/dmlc/README

This file was deleted.

Loading

0 comments on commit a506679

Please sign in to comment.