feat: Allowing # import in GraphQL
#141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: testTimeout
refactor: testTimeout
Use @apollo/client@3, @graphql-codegen/typescript-react-apollo@2
|
Congrats for this feature Soichi! 🎆 I was wondering what is the story for using fragments with the babel plugin? Also, does graphql-let export typescript types? I reuse them a lot when defining a fragment, for example : https://gist.github.com/jgoux/153804f6b9922127234ae9f595a754e4 I tried to contact you on Twitter but your DM are closed. 😄 |
piglovesyou
changed the title
# import in GraphQL# import in GraphQL
|
Hi @jgoux, thank you for reaching me! So currently CLI and babel can handle this, with I'm afraid I couldn't get 100% from your example, but yes, this change enables reusing GraphQL document fragments like this used by this. I hope this description works for you. Soon I'll announce v0.15.0 on Twitter so maybe some discussion will start there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65
Fixes #95