feat: Support writing QR code SVG and PNG to io.Writer #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josiah Adenegan <[email protected]>
Signed-off-by: Josiah Adenegan <[email protected]>
startnow65
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
+ Coverage 82.36% 84.12% +1.75%
==========================================
Files 5 5
Lines 1038 1058 +20
==========================================
+ Hits 855 890 +35
+ Misses 125 115 -10
+ Partials 58 53 -5 ☔ View full report in Codecov by Sentry. |
|
Great catch, maybe you should add some test cases to meet the needs of codecov. |
It will be a tricky one, but I'll try |
Signed-off-by: Josiah Adenegan <[email protected]>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for writing SVG and PNG to an
io.Writer.There is currently support to write the generated QR code directly to a file in these file formats.
There are, however, cases where the QR code is to be sent over the network. Without this feature, the workaround would be to write to a temporary file and then read that which is not convenient nor efficient.