Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix font preload warning #111

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Conversation

neilenns
Copy link
Contributor

Fixes #110

  • Remove the preload flag from the link

@pierr3
Copy link
Owner

pierr3 commented Jun 12, 2024

I mean without the preload flag, this will do nothing - I don't know why the warning appears when those fonts are loaded in CSS shortly after. This avoid a delay in the font rendering when opening the application

@neilenns
Copy link
Contributor Author

True, I should read more on preload before opening the PR 😬

I didn't notice any difference in rending without the preload. Don't forget that electron-vite now has the loading animation too, so there's tons of time for the font to load from resources?

@pierr3 pierr3 merged commit 53bf3fd into pierr3:main Jun 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Font preload warnings show in the console
2 participants