Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello, macOS 👋 (& system-supplied playback controls) #181

Open
wants to merge 62 commits into
base: main
Choose a base branch
from

Conversation

chriszielinski
Copy link

⚠️ Warning: this version has breaking changes. ⚠️

  • Full cross-platform support (macOS/iOS/tvOS).
    • Minimum deployment targets:
      • iOS 9.0
      • tvOS 9.0
      • macOS 10.10
  • System-supplied playback controls.
  • Refactor delegate protocols & FillMode to follow Swift nomenclature.
  • Add a few basic test cases (need a lot more).
  • Update readme.
  • Complete Travis CI suite (s/o to Regex for their Rakefile).
  • Carthage support.
  • Probably other stuff too, I don't remember.

Still needs

  • More test cases!!!!

lol meme

  • AVPlayerViewController implementation can be cleaned up. The double nested view controllers rub me the wrong way.
  • Did I already mention more test cases? Cause definitely that.

Thoughts? Comments? Concerns?

addbrick and others added 30 commits April 2, 2018 20:33
@piemonte
Copy link
Owner

hey, greatly appreciate the contributions. i typically prefer smaller PR's but i'll have to go through this and @addbrick contributions. i also need to split out the newer swift version changes to a new branch.

@piemonte piemonte mentioned this pull request Jun 25, 2020
Base automatically changed from master to main March 3, 2021 06:39
@tsheaff
Copy link
Contributor

tsheaff commented Sep 24, 2021

Is there a reason this never got merged? I actually misunderstood the purpose of this entire library and when it said "customizable UI and user interaction" I figured it would have nice default custom video playback controls, and that I'd be able to extend those to fit my needs. This seems like the main value add of a custom video player, no?

Since this is so old and has tons of conflicts now, I'm not planning to reply on this being merged any time soon. Do any of you know of alternative packages that offer custom video controls without needing to use AVPlayerViewController's UI (which is non-configurable) @piemonte @chriszielinski?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants