Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding first how-to guide as a basic example #486

Merged
merged 16 commits into from
Aug 7, 2024
Merged

Conversation

jimbobbennett
Copy link
Contributor

Created a first how-to guide for saving a snippet to show the basic structure.

Also added a contributing file with more details.

I've added the .vscode folder back to include settings for CSpell - the code spell checker. This sets things like enabling it for MDX files, and allows us to ingore certain words.

Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview Aug 7, 2024 8:15pm

Copy link
Contributor

@shivaypiece shivaypiece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all of the assets should go into the assets directory and only the .mdx file should be there in the docs section.

@jimbobbennett
Copy link
Contributor Author

jimbobbennett commented Jul 2, 2024

I think all of the assets should go into the assets directory and only the .mdx file should be there in the docs section.

Not personally a fan of that - you end up with an assets folder full of files and it's hard to track what is there. Great for some global files (logos etc.), but not for images relevant to docs. I prefer it in the relevant folder so it's easy to find the images.

Obviously will follow the standard if required, but would push for the standard to be putting images in the same folder as the markdown file.

@jimbobbennett jimbobbennett requested a review from shivaypiece July 2, 2024 21:22
@jimbobbennett jimbobbennett requested a review from shivaypiece July 2, 2024 21:33
Copy link
Contributor

@shivaypiece shivaypiece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mason-at-pieces
Copy link
Collaborator

@jimbobbennett @shivay-at-pieces So, about the assets being in the docs directory.

I agree that global assets are great to have in the assets folder. I'm fine with having one-off assets in their own respective folders. The assets folder has become quite messy just because it was started as a centralized location for storage.

For media that are used in multiple places, let's put them in the global static folder. For media that is specific to a page, put it inside a media folder. Inside that media folder, please also make folders for images, videos, etc so that is remains organized and not just a folder full of different types of files.

Copy link
Collaborator

@mason-at-pieces mason-at-pieces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move all webp files into a media/images folder so we keep the directory clean.

Also please move the helloworld.py file into a folder called resources

@shivaypiece
Copy link
Contributor

@mason-at-pieces you can have a look at the updated structure for the resources and media

@mason-at-pieces mason-at-pieces merged commit 2630d08 into main Aug 7, 2024
2 checks passed
@mason-at-pieces mason-at-pieces deleted the how-to-guides branch August 7, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants