-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding first how-to guide as a basic example #486
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all of the assets should go into the assets directory and only the .mdx file should be there in the docs section.
Not personally a fan of that - you end up with an assets folder full of files and it's hard to track what is there. Great for some global files (logos etc.), but not for images relevant to docs. I prefer it in the relevant folder so it's easy to find the images. Obviously will follow the standard if required, but would push for the standard to be putting images in the same folder as the markdown file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@jimbobbennett @shivay-at-pieces So, about the assets being in the docs directory. I agree that global assets are great to have in the assets folder. I'm fine with having one-off assets in their own respective folders. The For media that are used in multiple places, let's put them in the global |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move all webp
files into a media/images
folder so we keep the directory clean.
Also please move the helloworld.py
file into a folder called resources
@mason-at-pieces you can have a look at the updated structure for the resources and media |
Created a first how-to guide for saving a snippet to show the basic structure.
Also added a contributing file with more details.
I've added the
.vscode
folder back to include settings for CSpell - the code spell checker. This sets things like enabling it for MDX files, and allows us to ingore certain words.