Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix authentication with new authentication protocol #459

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

irakhlin
Copy link

…cloud-photos-downloader/icloud_photos_downloader/commit/4bcb2ac46a585205cbf3886b3df78179b34b18b1#diff-f2270f557e6afedd3e082f4dd8478d1c96dea051d6ea2e5b1229c0bb58d3d7f4R341

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New service (thank you!)
  • New feature (which adds functionality to an existing service)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation or code sample

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated to README

@PaulCavill
Copy link

PaulCavill commented Oct 24, 2024

@picklepete @coddingtonbear we are trying to get icloud in Home assistant working again, can you please review..

@PaulCavill
Copy link

@torarnv @Quentame

@karljtaylor
Copy link

impacting quite a few projects. think a few more places worth referencing, like this also shows up in issue #456

@PaulCavill
Copy link

@balloob can you help with this?

@gcobb321
Copy link
Contributor

gcobb321 commented Nov 13, 2024

@irakhlin @PaulCavill @codebar33
I had 2 users with valid passwords that failed to login. The passwords are:
qT*k74Ty]
latD620!

@codebar33 passed along code they are using at iMazing you may want to review. It corrects the problem caused by the password_hash not being calculated with the latest SRP-6A protocol.

See here and here

I am away so I have not been able to test this code update in iCloud3.

@gcobb321
Copy link
Contributor

@nzapponi
Nick, As I recall from a login time ago, you had code approval for pyicloud. Do you think you could help out here?

@PaulCavill
Copy link

PaulCavill commented Nov 13, 2024

@gcobb321 I have added the code in the links you provided, Will do some testing with the supplied passwords tomorrow.

irakhlin/pyicloud@master...PaulCavill:pyicloud:master

@irakhlin Can you please sync your fork.

@PaulCavill
Copy link

PaulCavill commented Nov 14, 2024

@gcobb321 After going through so many debug logs. I now have the 2 above passwords working on my install, by adding another Execption Handle to a try block.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants