Support Python 3.6 to 3.10 #371
Conversation
Drop support of Python < 3.6 - remove six + future deps + usage - update deps - remove encoding - remove (object)
| @@ -15,7 +17,6 @@ commands = | |||
| {envbindir}/pytest | |||
|
|
|||
| [testenv:lint] | |||
| basepython = python3 | |||
There was a problem hiding this comment.
Please keep this line.
There was a problem hiding this comment.
This really is a no-op nowadays, since the only supported Python is v3.
There was a problem hiding this comment.
The tox docs aren't totally clear exactly how the default python is set. It says system python. Not all systems have an executable under python when Python 3 is installed, including my own system, but it still works for me to remove this line.
https://tox.wiki/en/latest/example/general.html#basepython-defaults-overriding
Ok, let's remove it for now.
|
There are quite many pylint warnings for |
Co-authored-by: Martin Hjelmare <[email protected]>
Co-authored-by: Martin Hjelmare <[email protected]>
Co-authored-by: Martin Hjelmare <[email protected]>
Co-authored-by: Martin Hjelmare <[email protected]>
|
There are some lint warnings left to either resolve or disable and then we need to run black again with the updated version. |
|
Thanks! ❤️ 🎉 |
| @@ -6,7 +6,7 @@ | |||
|
|
|||
|
|
|||
| class AccountServiceTest(TestCase): | |||
| """"Account service tests""" | |||
| """ "Account service tests""" | |||
There was a problem hiding this comment.
Extra quote leftover.
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| # pylint: disable=pointless-statement | |||
| class DriveServiceTest(TestCase): | |||
| """"Drive service tests""" | |||
| """ "Drive service tests""" | |||
| @@ -5,7 +5,7 @@ | |||
|
|
|||
|
|
|||
| class FindMyiPhoneServiceTest(TestCase): | |||
| """"Find My iPhone service tests""" | |||
| """ "Find My iPhone service tests""" | |||
|
Fixed final comments in 8c7ba2a |
Rebase of #325. Looks like pushing to stale branches does not update the existing PR.
Breaking change
Proposed change
Drop support for Python versions which no longer have any upstream support. Improve forward compatibility up to Python 3.10.
This also should reduce dependency on older libraries, some of which are still pinned at old, insecure versions.
Type of change
Example of code:
n/a
Additional information
Fixes #289
Fixes #290
Closes #303
Closes #325
Checklist
If user exposed functionality or configuration variables are added/changed: