Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow accessories to be retrieved from the FindMyiPhone service #263

Merged
merged 2 commits into from
Apr 2, 2020
Merged

Conversation

k2on
Copy link
Contributor

@k2on k2on commented Apr 2, 2020

Proposed change

This will allow users to access their accessories (ex. Airpods) in the FindMyiPhone service.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New service (thank you!)
  • New feature (which adds functionality to an existing service)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation or code sample

Additional information

Functionality is the same but there are more devices listed.

Checklist

  • The code change is tested and works locally.
  • Local tests pass.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.
    same functionality as before

If user exposed functionality or configuration variables are added/changed:

None

  • Documentation added/updated to README

Copy link
Collaborator

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick and easy 😄

Thanks a lot, I was actually thinking of adding this.

Will test before merge 😉

@Quentame
Copy link
Collaborator

Quentame commented Apr 2, 2020

@k2on
Copy link
Contributor Author

k2on commented Apr 2, 2020

The deviceClass is Accessory

@Quentame
Copy link
Collaborator

Quentame commented Apr 2, 2020

The deviceClass is Accessory

For everything ? Airpods, Watch, HomePod ...

@k2on
Copy link
Contributor Author

k2on commented Apr 2, 2020

No just for the Airpods. The Apple watch is Watch but that was already included in the previous device list.
As for the HomePod, I just checked with someone that has a HomePod and he said it didn't show up in his devices on the iCloud Find My iPhone website. However I found this which means it showed up for someone else on Reddit.

https://www.reddit.com/r/HomePod/comments/azhr84/homepod_custom_name_not_showing_in_icloud/

@Quentame
Copy link
Collaborator

Quentame commented Apr 2, 2020

Thanks

@k2on
Copy link
Contributor Author

k2on commented Apr 2, 2020

I kept looking and found this which you already commented on so prob already know this but it says the HomePod class is HomePod

https://gist.github.com/insidegui/a18124c0c573a4eb656f5c485ea7dae4

@Quentame Quentame changed the title Allow for accessories to be retrieved for the FindMyIPhone service Allow accessories to be retrieved from the FindMyiPhone service Apr 2, 2020
Copy link
Collaborator

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working

@Quentame Quentame merged commit 057ede8 into picklepete:master Apr 2, 2020
@Quentame Quentame added this to the 1.0.0 milestone Apr 2, 2020
@Quentame Quentame modified the milestones: 1.0.0, 0.9.7 May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants