Fix 450 error

[Quentame]

• while refreshing client after 20 min of non request

Fixes #156

[reedriley]

I patched this diff locally to try it out (from within Home Assistant). My logs now show retry attempts when I encounter error 450, so that's great!

But then after several hours I see this error in the logs:

ERROR (MainThread) [homeassistant.config_entries] Error setting up entry <REDACTED> for icloud
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='setup.icloud.com', port=443): Max retries exceeded with url: <REDACTED> (Caused by NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x7f849c7b9150>: Failed to establish a new connection: [Errno -3] Try again'))
  File "/usr/src/homeassistant/homeassistant/components/icloud/__init__.py", line 124, in async_setup_entry
  File "/usr/src/homeassistant/homeassistant/components/icloud/account.py", line 100, in setup
    self._username, self._password, self._icloud_dir.path
  File "/usr/local/lib/python3.7/site-packages/pyicloud/base.py", line 203, in __init__
  File "/usr/local/lib/python3.7/site-packages/pyicloud/base.py", line 222, in authenticate
  File "/usr/local/lib/python3.7/site-packages/pyicloud/base.py", line 69, in request

After this error happens; I no longer see any further attempts to authenticate; no [pyicloud.services.findmyiphone.http] (450). Retrying ... lines, no successes and no failures.

Restarting Home Assistant fixes things. I suspect there are maybe two necessary bugfixes here; the first in pyicloud involving MaxRetryError and also in Home Assistant if there's any error handling you'd recommend be added to the icloud component.

[Quentame]

Hi @reedriley !

Thanks a lot for testing.

I think this gonna be fixed by #227 (because less requests).

Now that I am aware I'll tests better with your test case.

Actually fixing a lot of things in iCloud in HA.

[reedriley]

In that case, I'll patch #227 locally as well and let you know if anything breaks. 😁

[Quentame]

It breaks everything inside HA, you need https://github.com/Quentame/home-assistant/tree/icloud/fmi_reduce_battery_usage