Handle HTTP errors before trying to parse JSON#138
Merged
Conversation
a7b9af8 to
2fc59cb
Compare
|
@torarnv Change this definition: into: |
2fc59cb to
f1cbfca
Compare
Collaborator
Author
|
@mjj4791 all good? |
|
@torarnv Just replaced base.py with this version again... I usually see the error every 30 minutes, will let you know the results |
|
This fix seems to work; I still get an error, about every 30 minutes; but now it is a sensible exception that is catchable.... Please, let me know when you have a new version of the library out... 0.9.2? |
balloob
pushed a commit
to home-assistant/core
that referenced
this pull request
Aug 28, 2017
* Prevent iCloud exceptions in logfile With this change ValueError exceptions in the logfile caused by this component will disappear. These errors are caused by the iCloud API returning an HTTP 450 error and the external lib throwing a ValueError because of it. A PR has been raised against the external library, but that fix did not yet make it into a new version of the library. This will catch the exception in the mean time.... picklepete/pyicloud#138 * Align log messages
balloob
pushed a commit
to home-assistant/core
that referenced
this pull request
Aug 28, 2017
* Prevent iCloud exceptions in logfile With this change ValueError exceptions in the logfile caused by this component will disappear. These errors are caused by the iCloud API returning an HTTP 450 error and the external lib throwing a ValueError because of it. A PR has been raised against the external library, but that fix did not yet make it into a new version of the library. This will catch the exception in the mean time.... picklepete/pyicloud#138 * Align log messages
jacobhp-heni
pushed a commit
to jhads/pyicloud
that referenced
this pull request
Nov 27, 2025
Signed-off-by: Fahad Bandali <30586512+fahadbandali@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.