Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds missing body to URLRequest mapping. #991

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Adds missing body to URLRequest mapping. #991

merged 1 commit into from
Apr 15, 2022

Conversation

Miiha
Copy link
Contributor

@Miiha Miiha commented Sep 28, 2021 •
edited
Loading

Connection with issue(s)

Resolve issue #990

Testing and Review Notes

  1. Open a form which submits by sending a POST request.
  2. Override the shouldOverrideUrlLoading handler and see that navigationAction.request.body is no longer null.

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers

@ttb-inc ttb-inc mentioned this pull request Oct 1, 2021
Closed
@pichillilorenzo pichillilorenzo changed the base branch from master to develop April 15, 2022 21:58
@pichillilorenzo pichillilorenzo merged commit d2520ca into pichillilorenzo:develop Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrsed piotrsed piotrsed approved these changes

Assignees
No one assigned
Labels
iOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Miiha @piotrsed @pichillilorenzo