Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use in NavigationAction request toMap method #879

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

chreck
Copy link
Contributor

@chreck chreck commented Jun 14, 2021

Connection with issue(s)

Resolve issue #878

Testing and Review Notes

The request object is not a string anymore:

{"request":{"url":"https://www.google.com/","headers":null,"method":"GET","body":null,"iosAllowsCellularAccess":null,"iosAllowsConstrainedNetworkAccess":null,"iosAllowsExpensiveNetworkAccess":null,"iosCachePolicy":null,"iosHttpShouldHandleCookies":null,"iosHttpShouldUsePipelining":null,"iosNetworkServiceType":null,"iosTimeoutInterval":null,"iosMainDocumentURL":null},"isForMainFrame":true,"androidHasGesture":true,"androidIsRedirect":false,"iosWKNavigationType":null,"iosSourceFrame":null,"iosTargetFrame":null}

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • request the "UX" team perform a design review (if/when applicable)

@pichillilorenzo pichillilorenzo changed the base branch from master to develop April 15, 2022 21:40
@pichillilorenzo pichillilorenzo merged commit 604ca71 into pichillilorenzo:develop Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants