Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug when in String[] array come null #868

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

Ser1ous
Copy link
Contributor

@Ser1ous Ser1ous commented May 31, 2021

Connection with issue(s)

Resolve issue #867

Connected to #???

Testing and Review Notes

  1. Run application webview with form input file
  2. Click on input
  3. No crash app

Screenshots or Videos

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • request the "UX" team perform a design review (if/when applicable)

@arianneorpilla
Copy link

arianneorpilla commented Jul 10, 2021

Thanks for fixing this, this is like a month old PR but thought I'd mention my appreciation for having this fix. Figured it was just a missing null check somewhere that was probably super easy to spot but I couldn't for the life of me.

I couldn't import files into this web reader I'm trying to wrap into my application without crashing and this made it work. Got a new core feature into my app working with this pull request and my users are really happy for it, so I'm super grateful as I couldn't seem to get answers from the other issues for a while. It's like a one line fix but it really helped me out a lot.

@pichillilorenzo pichillilorenzo changed the base branch from master to develop April 15, 2022 21:31
@pichillilorenzo pichillilorenzo merged commit 45b6840 into pichillilorenzo:develop Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants