Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on nil/invalid URL (iOS) #262

Merged
merged 3 commits into from
May 9, 2020
Merged

Fix crash on nil/invalid URL (iOS) #262

merged 3 commits into from
May 9, 2020

Conversation

AlexV525
Copy link
Contributor

Connection with issue(s)

No unsolved issue, but might be similar to #74 and #174 .

Testing and Review Notes

Pass a url include whitespace (e.g. 'https://www.google.com '), app will crash immediately.
By adding this, there're still many codes using ! for force parsing, it require further modification.

To Do

Nothing needs to be handled.

@AlexV525 AlexV525 changed the title Fix crash on nil/invalid URL Fix crash on nil/invalid URL (iOS) Jan 17, 2020
@arnaudelub
Copy link

If you want, as the maintainer is out for quite a long time now, we are maintaining this fork:
https://github.com/arnaudelub/flutter_polywebview
package also available on pub.dev:
https://pub.dev/packages/flutter_polywebview

feel free to add you PR on this fork if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants