Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ios persistance when using sharedCookie #1093

Merged
merged 1 commit into from Apr 17, 2022
Merged

Fix ios persistance when using sharedCookie #1093

merged 1 commit into from Apr 17, 2022

Conversation

ghost
Copy link

@ghost ghost commented Feb 24, 2022 •
edited by ghost
Loading

Connection with issue(s)

Maybe a coding error, but in this function we should persist the local storage.

Connected to #???

#1092

Testing and Review Notes

Screenshots or Videos

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • request the "UX" team perform a design review (if/when applicable)

@pichillilorenzo pichillilorenzo changed the base branch from master to develop April 17, 2022 14:36
@pichillilorenzo pichillilorenzo changed the title Fix persistance Fix ios persistance when using sharedCookie Apr 17, 2022
@pichillilorenzo pichillilorenzo merged commit bee61b3 into pichillilorenzo:develop Apr 17, 2022
@pichillilorenzo
Copy link
Owner

It was a problem related to the wrong if statement! Now it has been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
iOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pichillilorenzo @EArminjon