updated shouldOverrideUrlLoading event for #146, added print method a…

…nd event #128, fix #123 javascript handler for Android API <= 22, renamed onTargetBlank to onCreateWindow event, deleted useOnTargetBlank option, added supportMultipleWindows android option, added getDefaultUserAgent static method, Updated default value for domStorageEnabled option to true
pichillilorenzo · Dec 9, 2019 · 9d5e1f5 · 9d5e1f5
1 parent 5858f2f
commit 9d5e1f5
Show file tree

Hide file tree

Showing 3 changed files with 65 additions and 41 deletions.
diff --git a/.idea/workspace.xml b/.idea/workspace.xml
diff --git a/README.md b/README.md
@@ -502,9 +502,10 @@ class MyInAppBrowser extends InAppBrowser {
   }
 
   @override
-  void shouldOverrideUrlLoading(ShouldOverrideUrlLoadingRequest shouldOverrideUrlLoadingRequest) {
+  Future<ShouldOverrideUrlLoadingAction> shouldOverrideUrlLoading(ShouldOverrideUrlLoadingRequest shouldOverrideUrlLoadingRequest) async {
     print("\n\n override ${shouldOverrideUrlLoadingRequest.url}\n\n");
     this.webViewController.loadUrl(url: shouldOverrideUrlLoadingRequest.url);
+    return ShouldOverrideUrlLoadingAction.CANCEL;
   }
 
   @override

diff --git a/example/lib/in_app_browser_example.screen.dart b/example/lib/in_app_browser_example.screen.dart
@@ -37,9 +37,10 @@ class MyInAppBrowser extends InAppBrowser {
   }
 
   @override
-  void shouldOverrideUrlLoading(String url, Map<String, String> headers, bool isForMainFrame) {
-    print("\n\n override $url\n\n");
-    this.webViewController.loadUrl(url: url);
+  Future<ShouldOverrideUrlLoadingAction> shouldOverrideUrlLoading(ShouldOverrideUrlLoadingRequest shouldOverrideUrlLoadingRequest) async {
+    print("\n\n override ${shouldOverrideUrlLoadingRequest.url}\n\n");
+    this.webViewController.loadUrl(url: shouldOverrideUrlLoadingRequest.url);
+    return ShouldOverrideUrlLoadingAction.CANCEL;
   }
 
   @override