Skip to content

Commit

Permalink
fix #213
Browse files Browse the repository at this point in the history
  • Loading branch information
pichillilorenzo committed Dec 18, 2019
1 parent 0e30767 commit 7d9f9f5
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
- Fix for Android and iOS `InAppBrowser` for some controller methods not exposed.
- Fixed "App Crashes after clicking on dropdown (Using inappwebview)" [#182](https://github.com/pichillilorenzo/flutter_inappwebview/issues/182)
- Fixed "webview can not be released when in ios" [#225](https://github.com/pichillilorenzo/flutter_inappwebview/issues/225). Now the iOS WebView is released from memory when it is disposed from Flutter.
- Fixed "Setting of presentationStyle not working on iOS" [#213](https://github.com/pichillilorenzo/flutter_inappwebview/issues/213)

### BREAKING CHANGES

Expand Down
1 change: 1 addition & 0 deletions ios/Classes/InAppBrowserManager.swift
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ public class InAppBrowserManager: NSObject, FlutterPlugin {
webViewController.webViewOptions = webViewOptions
webViewController.isHidden = browserOptions.hidden
webViewController.previousStatusBarStyle = previousStatusBarStyle
webViewController.prepareBeforeViewWillAppear()
return webViewController
}

Expand Down
4 changes: 3 additions & 1 deletion ios/Classes/InAppBrowserWebViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,9 @@ public class InAppBrowserWebViewController: UIViewController, FlutterPlugin, UIS
if browserOptions?.closeButtonColor != "" {
closeButton.tintColor = color(fromHexString: (browserOptions?.closeButtonColor)!)
}

}

public func prepareBeforeViewWillAppear() {
self.modalPresentationStyle = UIModalPresentationStyle(rawValue: (browserOptions?.presentationStyle)!)!
self.modalTransitionStyle = UIModalTransitionStyle(rawValue: (browserOptions?.transitionStyle)!)!
}
Expand Down

0 comments on commit 7d9f9f5

Please sign in to comment.