Add light theme #331
Open
Add light theme #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow selecting between built-in themes via "View" menu * Add basic mechanism to apply color changes at runtime * Add a basic light theme (needs still tweaking)
Prevents
```
/Users/runner/work/PianoBooster/PianoBooster/src/Cfg.h:77:5: error: defaulted definition of copy assignment operator is not constexpr
constexpr ColorTheme &operator=(const ColorTheme &other) = default;
^
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep it simply, loading a color theme from e.g. a JSON file is not part of this PR. However, the refactoring that is part of this PR should make it easy to add this kind of feature (so users don't need to recompile the application just to change colors). Of course it would also be easy to add more built-in themes.