Improve building with mingw-w64 #326
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der Linux The filesystem on Linux is case-sensitive so we need to get the casing right when compiling on Linux for Windows.
Apparently FTGL's CMake find module does not pull in the include path for FreeType 2 headers automatically. So we need to do that manually on our own. This code is relying on pkg-config for finding the include path. As pkg-config has been intentionally avoided for Windows builds I only enabled this for mingw-w64 builds so far (where pkg-config is usually available).
Using `using namespace std;` is a bad practice, especially in header files as it can lead to name collisions. In this case `std::byte` (from C++ 17) collided with `typedef unsigned char byte` (from the Windows header `rpcndr.h`) leading to many build errors.
* Link against FluidSynth at all (not sure how the Windows build has with FluidSynth enabled has ever been working without actually linking to the FluidSynth's library) * The imported target of FluidSynth does not automatically make the targets it depends on available. So we need to find the according packages manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't been able to link a build successfully as configuration with my static build of FluidSynth doesn't work yet