Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new dnssec.color instead of the removed dnssecClass variable #3197

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jan 21, 2025

What does this implement/fix?

See title. This fixes a hidden merge conflict that arose as regression of merging both #3184 and #3185 which had in parts incompatible changes.

Symptoms are failing tests on development as well as displaying issues on the Query Log for queries where EDE (extended DNS errors) are available (usually DNSSEC BOGUS queries).


Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@DL6ER DL6ER requested a review from a team January 21, 2025 18:40
@DL6ER DL6ER merged commit 9913f88 into development Jan 21, 2025
10 checks passed
@DL6ER DL6ER deleted the fix/dnssecClass branch January 21, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants