Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netlink tweaks #2168

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Netlink tweaks #2168

merged 4 commits into from
Jan 29, 2025

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jan 28, 2025

What does this implement/fix?

Following an issue report on Discourse, mentioning that not all interfaces were shown, I dived deeply into both the Netlink documentation as well as the kernel source code realizing that they are not always congruent. I modified our Netlink code in a way that would be consistent with how the kernel does it but still work if the way the kernel does it would be modified to behave as documented (I know this sounds a bit weird). In addition, we now have a lot of additional code that handles warning the user in case anything unexpected (most worth noticing would be Netlink packet truncation).

This PR adds the new config option debug.netlink obviously defaulting to false.

Extensively tested on three x86_64, a Raspberry Pi 1 B+, 4 and a 5 running the aarch64 kernel. On the latter, the problem was originally reported and I was able to reproduce it on this hardware.


Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

DL6ER added 4 commits January 25, 2025 12:23
…Linux kernel documentation. This also fixes a few issue with the current rpi-arm64 (aarch64) kernel

Signed-off-by: DL6ER <[email protected]>
@DL6ER DL6ER requested a review from a team January 28, 2025 19:10
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/interfaces-tab-only-shows-eth0-and-lo-interfaces/75338/22

@DL6ER DL6ER merged commit c7d3b8f into development Jan 29, 2025
18 checks passed
@DL6ER DL6ER deleted the tweak/nlinks branch January 29, 2025 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants