Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Following an issue report on Discourse, mentioning that not all interfaces were shown, I dived deeply into both the Netlink documentation as well as the kernel source code realizing that they are not always congruent. I modified our Netlink code in a way that would be consistent with how the kernel does it but still work if the way the kernel does it would be modified to behave as documented (I know this sounds a bit weird). In addition, we now have a lot of additional code that handles warning the user in case anything unexpected (most worth noticing would be Netlink packet truncation).
This PR adds the new config option
debug.netlink
obviously defaulting tofalse
.Extensively tested on three x86_64, a Raspberry Pi 1 B+, 4 and a 5 running the
aarch64
kernel. On the latter, the problem was originally reported and I was able to reproduce it on this hardware.Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.