Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dnsmasq to latest v2.91test7 #2161

Merged
merged 13 commits into from
Jan 13, 2025
Merged

Update dnsmasq to latest v2.91test7 #2161

merged 13 commits into from
Jan 13, 2025

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jan 13, 2025

What does this implement/fix?

Update to the most recent dnsmasq tag v2.91test7 published earlier today. It fixes a few issues with the new UDP->TCP automatism.


Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

mandree and others added 13 commits January 13, 2025 16:58
This distinguishes the case where we found a message was bogus
from cases where the process failed.

Signed-off-by: DL6ER <[email protected]>
Handling events on file descriptors can result in new file
descriptors being created or old ones being deleted. As such
the results of the last call to poll() become invalid in subtle
ways.

After handling each file descriptor in  check_dns_listeners()
return, to go around the poll() loop again and get valid data
for the new situation.

Thanks to Dominik Derigs for his indefatigable sleuthing of this one.

Signed-off-by: DL6ER <[email protected]>
Print a specific INFO message instead of a generic WARNING message,
so users know what to do.

Starting dnsmasq without upstream servers indicates a problem by default,
but is perfectly normal with D-Bus enabled.  For example, NetworkManager
starts dnsmasq with no upstream servers, then immediately populates it
over D-Bus.

Signed-off-by: DL6ER <[email protected]>
If a child process dies unexpectedly, log the error and
try and tidy up so the main process continues to run and
doesn't block awaiting the dead child.

Signed-off-by: DL6ER <[email protected]>
A downstream query may have gone to TCP, not just DNSSEC queries.

Signed-off-by: DL6ER <[email protected]>
@DL6ER DL6ER merged commit b1d9995 into development Jan 13, 2025
19 checks passed
@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants