Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible turnaround overflow #2158

Merged
merged 3 commits into from
Jan 12, 2025
Merged

Fix possible turnaround overflow #2158

merged 3 commits into from
Jan 12, 2025

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jan 12, 2025

What does this implement/fix?

Fix a value overflow in the rate-limiting diagnosis message reported on Discourse.


Related issue or feature (if applicable): https://discourse.pi-hole.net/t/client-has-been-rate-limited-for-at-least-3217188-seconds/75091

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/client-has-been-rate-limited-for-at-least-3217188-seconds/75091/9

src/gc.c Fixed Show fixed Hide fixed
@yubiuser
Copy link
Member

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Dominik <[email protected]>
@DL6ER DL6ER marked this pull request as ready for review January 12, 2025 12:08
@DL6ER DL6ER requested a review from a team January 12, 2025 12:08
@DL6ER DL6ER merged commit dac2dec into development Jan 12, 2025
20 checks passed
@DL6ER DL6ER deleted the fix/turnaround branch January 12, 2025 18:57
@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants