Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow .ssh directory to be mounted on MacOS host #2152

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Allow .ssh directory to be mounted on MacOS host #2152

merged 1 commit into from
Jan 4, 2025

Conversation

PromoFaux
Copy link
Member

@PromoFaux PromoFaux commented Jan 4, 2025 •
edited
Loading

What does this PR aim to accomplish?:

This should still work on any linux distro too!

Annoyingly MacOS uses /Users/ rather than /home/ - but all distros should have $HOME

https://apple.stackexchange.com/a/86415

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  • I have read the above and my PR is ready for review. Check this box to confirm

@PromoFaux PromoFaux requested a review from DL6ER January 4, 2025 19:11
DL6ER
DL6ER approved these changes Jan 4, 2025
View reviewed changes
Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working on Ubuntu 24.04 at least

@PromoFaux PromoFaux merged commit 01202c6 into development Jan 4, 2025
18 checks passed
@PromoFaux PromoFaux deleted the tweak/devcontainer branch January 4, 2025 22:06
@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DL6ER DL6ER DL6ER approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PromoFaux @DL6ER