Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden dnsmasq syntax checking against signals #2151

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jan 2, 2025

What does this implement/fix?

Retry to wait for result of dnsmasq syntax test if interrupted by a signal


Related issue or feature (if applicable): #2149

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@DL6ER DL6ER changed the title Harden dnsmasq syntac checking against signals Harden dnsmasq syntax checking against signals Jan 2, 2025
@DL6ER DL6ER marked this pull request as ready for review January 3, 2025 01:11
@DL6ER DL6ER requested a review from a team January 3, 2025 01:11
@DL6ER
Copy link
Member Author

DL6ER commented Jan 3, 2025

Fix confirmed by OP in #2149

@DL6ER DL6ER merged commit dc59611 into development Jan 3, 2025
19 checks passed
@DL6ER DL6ER deleted the fix/dnsmasq_test_signal branch January 3, 2025 06:31
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/invalid-configuration-dnsmasq-syntax-check-ok/74928/2

@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants