Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Remove NTP test #2148

Merged
merged 1 commit into from
Jan 2, 2025
Merged

CI: Remove NTP test #2148

merged 1 commit into from
Jan 2, 2025

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jan 2, 2025

What does this implement/fix?

This PR removes the NTP test from FTL's CI testing suite. The reason for this is that this test is failing > 75% of the time, triggering automatic retries unnecessarily lengthening the overall build process and wasting resources.

image

But it is actually not only wasting resources but also causes more than 80% of the docker-base-images/ftl-build to fail at least one of the jobs, preventing updating the build container altogether.

There simply seems to be no reliable way to get this working. The underlying issue is somewhat hard to analyze, however, it seems that the NTP server simply is firewalled away on most (but not all) GHA runners.


Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

Signed-off-by: DL6ER <[email protected]>
@DL6ER DL6ER requested a review from a team January 2, 2025 11:56
@DL6ER DL6ER enabled auto-merge January 2, 2025 12:10
@DL6ER DL6ER merged commit b391c6a into development Jan 2, 2025
18 checks passed
@DL6ER DL6ER deleted the test/no_ntp branch January 2, 2025 12:30
@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants