Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCC 14.2.0 support #2133

Merged
merged 4 commits into from
Dec 10, 2024
Merged

GCC 14.2.0 support #2133

merged 4 commits into from
Dec 10, 2024

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Dec 9, 2024

What does this implement/fix?

A few changes without functional changes needed to get compatible with Alpine 3.21 (GCC 14.2 and Linux 6.12).

Opening as draft right now as we can update the building container only when it has been tagged.


Related issue or feature (if applicable): pi-hole/docker-base-images#100

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

DL6ER added 3 commits December 9, 2024 10:24
…. The current implementation mixed it in a harmless way, however, it is generating a warning in GCC 14 and up. Also, reduce code duplication

Signed-off-by: DL6ER <[email protected]>
@DL6ER DL6ER changed the title Ensure GCC 14.2.0 support GCC 14.2.0 support Dec 9, 2024
@DL6ER
Copy link
Member Author

DL6ER commented Dec 9, 2024

Note: The failing 386 test is expected. file's output changed. This test will pass once we use the newer container.

Signed-off-by: DL6ER <[email protected]>
@DL6ER DL6ER requested a review from a team December 9, 2024 20:34
@DL6ER DL6ER marked this pull request as ready for review December 9, 2024 20:34
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just maybe one of the functions could be renamed a bit, I think they are quite similar and easy to get mixed.

check_capability and check_capabilities

@DL6ER
Copy link
Member Author

DL6ER commented Dec 10, 2024

Their very similar names are intentionally the way they are. One requires an argument (checking for one), the other not (checking for all). IMO this is sufficient as extra distinction.

@DL6ER DL6ER merged commit 91ea8d4 into development Dec 10, 2024
20 checks passed
@DL6ER DL6ER deleted the new/alpine_v3.21 branch December 10, 2024 18:38
@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants