Skip to content

Pluses and spaces #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matt-phylum merged 3 commits into from
Nov 20, 2023
Merged

Pluses and spaces #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c474b1
escape plus signs in qualifier values
matt-phylum Nov 7, 2023
3643b11
include tests for unsupported package types
matt-phylum Nov 7, 2023
a9f5829
document additional escaping
matt-phylum Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion purl/src/format.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ const PATH: &AsciiSet = &QUERY.add(b'?').add(b'`').add(b'{').add(b'}');
// be escaped except when used as a separator.
const PURL_PATH: &AsciiSet = &PATH.add(b'@').add(b'?').add(b'#');
const PURL_PATH_SEGMENT: &AsciiSet = &PURL_PATH.add(b'/');
const PURL_QUERY: &AsciiSet = &QUERY.add(b'@').add(b'?').add(b'#');
// For compatibility with PURL implementations that treat qualifiers as
// form-urlencoded, escape '+' as well.
const PURL_QUERY: &AsciiSet = &QUERY.add(b'@').add(b'?').add(b'#').add(b'+');
const PURL_FRAGMENT: &AsciiSet = &FRAGMENT.add(b'@').add(b'?').add(b'#');

impl<T> fmt::Display for GenericPurl<T>
Expand Down
12 changes: 12 additions & 0 deletions purl/src/package_type.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,18 @@ use crate::{
/// but this implementation does not convert them to lowercase. Go modules can
/// have mixed case names, and mixed case names are distinct.
/// ([package-url/purl-spec#196])
/// - Some implementations treat '+' in qualifiers as '+' and some
/// implementations treat '+' as ' '. This implementation treats '+' as '+'
/// because there is nothing in the spec that says they should be ' '.
/// However, even though the spec never references x-www-form-urlencoded,
/// qualifiers look like x-www-form-urlencoded, and in x-www-form-urlencoded,
/// '+' means ' '. For compatibility with other implementations, this
/// implementation escapes '+' as %2B in qualifiers, avoiding ambiguous
/// parsing at the cost of making the PURL more difficult for humans to read.
/// Some implementations also convert '+' to ' ' in other parts of the PURL,
/// including in version numbers where they can be common, but this
/// implementation does not escape '+' there because that is an implementation
/// error, not a spec ambiguity.
///
/// [package-url/purl-spec#226]: https://github.com/package-url/purl-spec/issues/226
/// [package-url/purl-spec#165]: https://github.com/package-url/purl-spec/pull/165
Expand Down
Loading