addressing the confusion in issue #459 #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingdonb
changed the title
|
I am pretty sure that one of my suggested options for configuration won't work, that is, you can't put these ENV variables in a child image after the baseimage-docker parent is already built... it is "buildconfig" and that will be too late. |
kingdonb
changed the title
|
That's better... there is really a very narrow window of time (before the baseimage is built) where these values can be set to any effect. There used to be some guidance about disabling services in child images at runtime that I can't find readily in the README just now; this configuration change would be used instead to ensure that the services that are not desired don't get installed at all (thereby making the baseimage size smaller.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some confusion about where the environment variables are placed such as
DISABLE_CRON,DISABLE_SYSLOG,DISABLE_SSH. This PR should serve to clarify that you cannot justDISABLE_CRON=1 make buildbut you actually need to provide these variables to the Docker build,in a child image's Dockerfile (? on second thought, does this strategy actually work? test before merge) orin options passed to Docker during the build.