Skip to content

docs(README): Add more daemon info #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2018
Merged

Conversation

codywl
Copy link
Contributor

@codywl codywl commented Sep 4, 2018

#498

Gives the "Adding Additional Daemons" section of the README some extra
information, including another warning not to use -it <cmd> when
starting a given container.

Sorry for the long wait! I'll be taking this revision process one section at a time. These changes also add syntax highlighting via GitHub's flavor of Markdown. Hopefully, we can start to hone in on a particular style. :)

Gives the "Adding Additional Daemons" section of the README some extra
information, including another warning not to use `-it <cmd>` when
starting a given container.
@kingdonb
Copy link
Collaborator

kingdonb commented Sep 4, 2018

This looks pretty good, but one thing I'm not sure about:

by default - restart it upon its exit, after waiting one second

This is the default behavior of runit, but is it the behavior of baseimage-docker? I am pretty sure if runit detects any service crashed, the whole container will restart. I haven't tested this recently (so it's possible I'm recalling a bug that has already been fixed.)

I'd like to give it a second once-over before giving it the OK, when I have a little more time to read it over carefully and check for any minor issues like grammatical things I might not have noticed.

(I'm in a bit of a rush today...)

Oh and thanks so much for your contribution!

@codywl
Copy link
Contributor Author

codywl commented Sep 5, 2018

Hey,

Sounds good to me. I'll respond to any requests as soon as I see them. :)

Hope to hear back soon!

@rdxmb
Copy link
Contributor

rdxmb commented Sep 5, 2018

I am pretty sure if runit detects any service crashed, the whole container will restart.

Definitely not. I sometimes kill a service by its ID just to see what happens. Runit always does only start THAT service again.

Copy link
Collaborator

@Theaxiom Theaxiom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@Theaxiom Theaxiom added this to the 0.11.1 milestone Sep 14, 2018
@Theaxiom Theaxiom merged commit 3b51162 into phusion:master Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants