Improve EnumSanityRule

[VincentLanglet]

Closes phpstan/phpstan#13768

[VincentLanglet]

The message changed from

Enum %s is not backed, but case %s has value %s.

to

Enum %s is not backed, but case %s has value.

I'm not sure you're okay with this or if

• it should be behind bleedingEdge
• it should be behind some extra condition (and have two differents messages ?)

[ondrejmirtes]

Why would the message change? If it has value, we can still include it in the error message.

[VincentLanglet]

The check was

if ($stmt->expr instanceof Node\Scalar\Int_ || $stmt->expr instanceof Node\Scalar\String_) {

and is changed to

if ($enumNode->scalarType === null && $stmt->expr !== null) {

so I cannot safely access to $stmt->value

I made 8e72e2b to revert this change for Int/String/Float, but the test show the issue with other things like

	case E = false;
	case F = Foo::A;

where no value is displayed. Is there some helper method to get a value/name from an Expr ? Or is it ok like this ?

[ondrejmirtes]

You can either use ExprPrinter on $stmt->expr, or you can get type of $stmt->expr with InitializerExprTypeResolver and do ->describe(VerbosityLevel::value()) on the type. I like the 2nd option more.

[VincentLanglet]

By setting enum cases value here, instead of in the condition

if ($stmt->expr instanceof Node\Scalar\Int_ || $stmt->expr instanceof Node\Scalar\String_)

I also catch other constant values like the one set with a class Constant.

Cf test

enum Backed: int {
	case One = Foo::A;
	case Two = Foo::A;
}

[ondrejmirtes]

CS build fail