More precise mixed-type subtraction #3420
Open
+67
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Sep 8, 2024
staabm
commented
Sep 8, 2024
staabm
force-pushed
the
mixsub
branch
2 times, most recently
from
a26a7a0
to
1f9a3bf
Compare
ondrejmirtes
requested changes
Sep 9, 2024
|
after a break and thinking about your feedback, I came to a new implementation idea :). |
staabm
commented
Sep 12, 2024
|
|
||
| if ($m != false) { | ||
| assertType("mixed~0|0.0|''|'0'|array{}|false|null", $m); | ||
| assertType('int<min, -1>|int<1, max>', (int) $m); |
There was a problem hiding this comment.
running my new tool thru this test, told me that (int) $m can still be zero at this point:
we already knew that because ondrey told us - but as of now I can find this errors myself without wasting his time
|
just reduced this PR to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
realized this nit while looking more into division related types