apply parameter closure type extension in FunctionCallParametersCheck #3347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought about this. I thought I wanted a different solution using virtual nodes but it'd need a lot of refactoring. And maybe it'd still be very hard. For similar reasons I already added $scope->pushInFunctionCall() in the same Check class. So feel free to pursue the same direction you started 😊 |
schlndh
force-pushed
the
feature-applyParameterClosureTypeExtensionInFuncCallCheck
branch
2 times, most recently
from
ee278fc
to
3d593f5
Compare
schlndh
commented
Aug 26, 2024
schlndh
commented
Aug 26, 2024
schlndh
force-pushed
the
feature-applyParameterClosureTypeExtensionInFuncCallCheck
branch
from
74e9ac6
to
1665c48
Compare
|
This pull request has been marked as ready for review. |
schlndh
force-pushed
the
feature-applyParameterClosureTypeExtensionInFuncCallCheck
branch
from
7fda20c
to
f63df3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://phpstan.org/r/8ff9bc8f-4162-4ccf-bf5c-8b3d2061e68d
Partially fixes: phpstan/phpstan#10396
Related to #3282 (comment)