Do not use "strtolower" when there is a dedicated method

phpstan · Dec 11, 2022 · bc0a290 · bc0a290
1 parent f9bfc19
commit bc0a290
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 9 deletions.
diff --git a/src/Rules/PHPUnit/AssertSameBooleanExpectedRule.php b/src/Rules/PHPUnit/AssertSameBooleanExpectedRule.php
@@ -10,7 +10,6 @@
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
 use function count;
-use function strtolower;
 
 /**
  * @implements Rule<NodeAbstract>
@@ -35,7 +34,7 @@ public function processNode(Node $node, Scope $scope): array
 		if (count($node->getArgs()) < 2) {
 			return [];
 		}
-		if (!$node->name instanceof Node\Identifier || strtolower($node->name->name) !== 'assertsame') {
+		if (!$node->name instanceof Node\Identifier || $node->name->toLowerString() !== 'assertsame') {
 			return [];
 		}
 

diff --git a/src/Rules/PHPUnit/AssertSameNullExpectedRule.php b/src/Rules/PHPUnit/AssertSameNullExpectedRule.php
@@ -10,7 +10,6 @@
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
 use function count;
-use function strtolower;
 
 /**
  * @implements Rule<NodeAbstract>
@@ -35,7 +34,7 @@ public function processNode(Node $node, Scope $scope): array
 		if (count($node->getArgs()) < 2) {
 			return [];
 		}
-		if (!$node->name instanceof Node\Identifier || strtolower($node->name->name) !== 'assertsame') {
+		if (!$node->name instanceof Node\Identifier || $node->name->toLowerString() !== 'assertsame') {
 			return [];
 		}
 

diff --git a/src/Rules/PHPUnit/AssertSameWithCountRule.php b/src/Rules/PHPUnit/AssertSameWithCountRule.php
@@ -11,7 +11,6 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Type\ObjectType;
 use function count;
-use function strtolower;
 
 /**
  * @implements Rule<NodeAbstract>
@@ -36,7 +35,7 @@ public function processNode(Node $node, Scope $scope): array
 		if (count($node->getArgs()) < 2) {
 			return [];
 		}
-		if (!$node->name instanceof Node\Identifier || strtolower($node->name->name) !== 'assertsame') {
+		if (!$node->name instanceof Node\Identifier || $node->name->toLowerString() !== 'assertsame') {
 			return [];
 		}
 
@@ -45,7 +44,7 @@ public function processNode(Node $node, Scope $scope): array
 		if (
 			$right instanceof Node\Expr\FuncCall
 			&& $right->name instanceof Node\Name
-			&& strtolower($right->name->toString()) === 'count'
+			&& $right->name->toLowerString() === 'count'
 		) {
 			return [
 				'You should use assertCount($expectedCount, $variable) instead of assertSame($expectedCount, count($variable)).',
@@ -55,7 +54,7 @@ public function processNode(Node $node, Scope $scope): array
 		if (
 			$right instanceof Node\Expr\MethodCall
 			&& $right->name instanceof Node\Identifier
-			&& strtolower($right->name->toString()) === 'count'
+			&& $right->name->toLowerString() === 'count'
 			&& count($right->getArgs()) === 0
 		) {
 			$type = $scope->getType($right->var);

diff --git a/src/Rules/PHPUnit/ShouldCallParentMethodsRule.php b/src/Rules/PHPUnit/ShouldCallParentMethodsRule.php
@@ -97,7 +97,7 @@ private function hasParentClassCall(?array $stmts, string $methodName): bool
 				continue;
 			}
 
-			if (strtolower($stmt->expr->name->name) === $methodName) {
+			if ($stmt->expr->name->toLowerString() === $methodName) {
 				return true;
 			}
 		}