[WIP] ContactUs package

[unckleg]

I have problem for sending POST onto Web Action.
I need to provide form filtering/error preview for ContactUsAction (Created view script, form, routes).
If someone can see where i came up and provide some hints.

TODO:

• Write tests for whole package parts (Admin/Web).
• Support for reCAPTCHA / MailChimp

[unckleg]

Also is there any need for providing composer.json file as part of this PR ?

[tasmaniski]

You can put (string) here too.

[tasmaniski]

Here (and in all code generaly) you can use PHP7 return type.
there will be recommended to return ContactUs entity.
In that case you should check if result is null and throw exception if it is.
Mapper will return ContactUs by default.

We are planning to add return types in all code :)

[tasmaniski]

Sry for the delay I hope that next time I will be faster.

What you can improve:

• Use return types in all methods for cleaner and stable code. Specially when you need to return entity object

• From the service, move Mapper's methods in Mapper, like:
  $this->mapper->insert($data); or $this->mapper->select([...]);
  this should goes to mapper.
  In same case use entity for passing the data. for eg.

service:
$this->mapper->insertContact($contactUsEntity); 

mapper:
$this->insert($contactUsEntity->getArray());

• Than you can add types in the methods also. In mapper
  ContactUsMapper()::insertContact(ContactUs $contactUsEntity);
• For the phone validation you can use https://github.com/giggsey/libphonenumber-for-php but it is not necessary in this stage.

Everything else is perfect :)

[unckleg]

Thanks for feedback, I'll send PR soon :)