Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes phpro/grumphp-shim#10
This PR makes sure that the GrumPHP
TaskInterface
only has a dependency to theGrumPHP\\
namespace.Symfony OptionsResolver will not be a part of the task interface anymore.
New task interface:
This makes it possible for extensions to provide tasks that are compatible with the
grumphp-shim
release.In order to make the task compatible, you'll need to wrap the symfony options-resolver with GrumPHP's own options-resolver:
❗ In extensions, you do not want to use
\GrumPHP\Task\Config\ConfigOptionsResolver::fromOptionsResolver()
- since Symfony's options resolver will be scoped (prefixed) ingrumphp-shim
's phar distrubition.