Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/593 v5.10.x and v5.11.x #614

Open
wants to merge 2 commits into
base: 5.10.x
Choose a base branch
from

Conversation

niconoe-
Copy link
Contributor

@niconoe- niconoe- commented Feb 3, 2025

Fixes #593
Fixes #497

Same as #613 but for v5.10.x and v5.11.x

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.85%. Comparing base (afe9173) to head (4e763f1).
Report is 80 commits behind head on 5.10.x.

Additional details and impacted files
@@             Coverage Diff              @@
##             5.10.x     #614      +/-   ##
============================================
+ Coverage     96.81%   96.85%   +0.03%     
  Complexity     2294     2294              
============================================
  Files            70       71       +1     
  Lines          5248     5175      -73     
============================================
- Hits           5081     5012      -69     
+ Misses          167      163       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niconoe-
Copy link
Contributor Author

niconoe- commented Feb 3, 2025

Lint on PHP 7.4 is failing on something that is not part of the current PR modification (see #611 which has the same issue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant