Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redundant whitespaces - Issue #227 #228

Merged
merged 2 commits into from
Feb 26, 2019

Conversation

pszalko
Copy link
Contributor

@pszalko pszalko commented Feb 15, 2019

Changed implementation of build() methods to generate more consistent SQL.

This commit fixes implementation of build() methods to produce more consistent SQL code without redundant spaces.

… SQL.

This commit fixes implementation of `build()` methods to produce more consistent SQL code without redundant spaces.
@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@dc4c38a). Click here to learn what that means.
The diff coverage is 100%.

@@           Coverage Diff            @@
##             master    #228   +/-   ##
========================================
  Coverage          ?   99.7%           
  Complexity        ?    1841           
========================================
  Files             ?      61           
  Lines             ?    4104           
  Branches          ?       0           
========================================
  Hits              ?    4092           
  Misses            ?      12           
  Partials          ?       0

Copy link
Member

@devenbansod devenbansod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @pszalko !

@williamdes
Copy link
Member

@devenbansod You can merge this one :)

@devenbansod devenbansod merged commit b3e7bfc into phpmyadmin:master Feb 26, 2019
devenbansod added a commit that referenced this pull request Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants