Add ENV PMA_UPLOADDIR and PMA_SAVEDIR ENVs#384
Merged
williamdes merged 4 commits intophpmyadmin:masterfrom Nov 25, 2022
chrisproud:dir-envvars
Merged
Add ENV PMA_UPLOADDIR and PMA_SAVEDIR ENVs#384williamdes merged 4 commits intophpmyadmin:masterfrom chrisproud:dir-envvars
williamdes merged 4 commits intophpmyadmin:masterfrom
chrisproud:dir-envvars
Conversation
williamdes
reviewed
Sep 20, 2022
williamdes
approved these changes
Sep 21, 2022
williamdes
reviewed
Sep 21, 2022
Co-authored-by: William Desportes <williamdes@wdes.fr>
williamdes
approved these changes
Sep 21, 2022
Member
|
@MauricioFauth @ibennetch If you have no objection I will merge this one soon and document it on the main repository |
MauricioFauth
approved these changes
Sep 21, 2022
Author
|
@williamdes , anything I can do to help fix this broken test? |
Member
Nevermind, I restarted the job. It's on my todo list I will write a test for this feature and merge it :) |
williamdes
changed the title
williamdes
added a commit
that referenced
this pull request
Nov 25, 2022
williamdes
added a commit
that referenced
this pull request
Nov 25, 2022
Member
williamdes
added a commit
to phpmyadmin/phpmyadmin
that referenced
this pull request
Nov 25, 2022
Ref: - phpmyadmin/docker#384 - phpmyadmin/docker#381 Signed-off-by: William Desportes <williamdes@wdes.fr>
Member
|
Deployed on https://hub.docker.com/_/phpmyadmin ! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When hosting this image on an Azure hosted container instance, I can mount an Azure FileShare to a local path for uploads but I can't add custom file to the local volume to set the configuration.
This PR adds support setting the UploadDir and SaveDir through environment variables.